Remove negative-margin-top class
What does this MR do?
Part of #239861 (closed) removes the negative-margin-top
class in pipelines.scss
. Depends on !42944 (merged)
Users can click on "Run Pipeline" to start their pipelines on merge requests.
Previously, the layout was achieved by repurposing the "Run pipeline" button so it shows in the right place in mobile and desktop by adding a negative margins, this made for a fragile layout.
Now this is done by adding a slot to place the button inside the table, and an additional block button for mobile views.
Screenshots
There should be no obvious changes!
before | after |
---|---|
![]() |
![]() |
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon