Skip to content

Drop Iglu registry URL column

Alper Akgun requested to merge 244828-drop-iglu-registry-url-column into master

What does this MR do?

Drops Iglu registry URL column

The second step for 3-release column removal #244828 (closed) and a followup of the MR "Ignoring the column (release M)" !41556 (merged)

Migration output

$ bin/rails db:migrate:up VERSION=20200922054642
== 20200922054642 DropSnowplowIgluRegistryUrlFromApplicationSettings: migrating 
-- remove_column(:application_settings, :snowplow_iglu_registry_url, :string, {:limit=>255})
   -> 0.0010s
== 20200922054642 DropSnowplowIgluRegistryUrlFromApplicationSettings: migrated (0.0011s) 

$ bin/rails db:migrate:down VERSION=20200922054642
== 20200922054642 DropSnowplowIgluRegistryUrlFromApplicationSettings: reverting 
-- add_column(:application_settings, :snowplow_iglu_registry_url, :string, {:limit=>255})
   -> 0.0010s
== 20200922054642 DropSnowplowIgluRegistryUrlFromApplicationSettings: reverted (0.0019s) 

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alper Akgun

Merge request reports