Skip to content

Remove N+1 in license scanning report comparison

What does this MR do?

This change removes a N+1 that occurs when viewing a diff of license scanning reports. This was caused by fetching the software license policy for each detected license in a report during JSON serialization. I have updated this code to utilize the LicenseCompliance class that loads the necessary reported licenses and software licenses policies more efficiently.

Screenshots

screenshot-2020-09-23-1600892452

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by mo khan

Merge request reports

Loading