Skip to content

Optimise cleaning up LFS objects

Nick Thomas requested to merge 238605-optimise-lfs-cleanup into master

What does this MR do?

The GetAllLfsPointers RPC is quite expensive, and we're running as part of GitGarbageCollectWorker as well as manually.

Since all it does is remove links between Project and LfsObject, we can skip running it at-all if the project has 0 LFS objects linked.

We can also catch and log errors so that gc won't be negatively affected if a timeout does occur here.

Another option would be to split it out into another worker entirely, which might be a touch clearer, but I'll leave that decision to reviewer/maintainer.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #238605 (closed)

Edited by Nick Thomas

Merge request reports