Skip to content

Replace the delete SSH confirmation dialog with GlModal

What does this MR do?

This MR replaces the existing browser-default confirmation dialog with a GlModal variant using the brilliant shared modal component: !25471 (merged).

This replacement is specifically for the users sections of the admin area and the users profile.

This also updates the wording of the deletion buttons from "Remove" to "Delete" so it aligns properly with our documentation and the general wording we are using across the product.

Screenshots

Page view

Path Before After
[HOST]/admin/users/[USERNAME]/keys image image
[HOST]/admin/users/[USERNAME]/keys/[ID] image image
[HOST]/profile/keys image image
[HOST]/profile/keys/[ID] image image

Modal view

Path Before After
[HOST]/admin/users/[USERNAME]/keys image image
[HOST]/admin/users/[USERNAME]/keys/[ID] image image
[HOST]/profile/keys image image
[HOST]/profile/keys/[ID] image image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Go the paths above and confirm that the modal appears and that you can cancel the action or continue to delete the key and see it is deleted across the product.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related #235945 (closed)

Edited by Robert Hunt

Merge request reports