Remove QA selector props from audit logs and make them generic
requested to merge 222268-follow-up-remove-dynamic-qa-selectors-from-audit-logs-template-and-make-them-generic into master
What does this MR do?
This MR tidies up the QA selectors leftover from the migration of audit logs from HAML to a Vue app.
Initially, we kept the existing QA selectors so we could confirm the changes worked as before.
Now all the audit logs go through the same code, we can remove the dynamic QA selectors (admin_, group_ and project_) and replace them with hardcoded equivalents.
This reduces the complexity of the Vue app's props and removes unnecessary reactivity.
Screenshots
No visual changes, this is purely a codebase tidy-up
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
-
Separation of EE specific content
Availability and Testing
The QA tests should pass
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Related #222268 (closed)
Edited by Robert Hunt