Skip to content

Move before_script into script for CQ template

Vicken Simonian requested to merge vicken.papaya/gitlab:patch-238 into master

What does this MR do?

This MR moves the before_script contents into script to prevent inadvertent overriding of the before_script section by template users. If template users define a before_script to docker login ... to be able to pull an image from a private forked repository, they override the setting of the important SOURCE_CODE environment variable.

Solves #249361 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Erick Bajao

Merge request reports