Skip to content

Fix intermittent clone failure in QA

Michael Kozono requested to merge qa/mk-fix-intermittent-clone-failure into master

What does this MR do?

Attempts to fix intermittent git clone failure in QA specs. I am 85% sure this fixed it because we use background jobs involving Gitaly after creating a project.

The git URI was the SSH one instead of HTTP, which suggests selecting HTTP from the dropdown didn't work. So I have treated this as another "clicked too quickly before the dropdown JS was bound".

I believe it is possible that the dropdown toggle could be a race condition, but it turns out through trial-and-error that the textbox update causes these errors on my machine, and I haven't seen the error over 10 trials now.

Are there points in the code the reviewer needs to double check?

Why was this MR needed?

GitLab Geo project replication
Cloning into '.'...
ssh: Could not resolve hostname localhost:2222: nodename nor servname provided, or not known
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: not in a git directory
fatal: not in a git directory
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
fatal: Not a git repository (or any of the parent directories): .git
WARN: Screenshot could not be saved. `page.current_path` is empty.
  users pushes code to the primary node (FAILED - 2)

<snip>

2) GitLab Geo project replication users pushes code to the primary node
     Failure/Error: expect(page).to have_content 'This is Geo project!'
       expected to find text "This is Geo project!" in <snip>

Screenshots (if relevant)

Does this MR meet the acceptance criteria?

What are the relevant issue numbers?

Edited by Michael Kozono

Merge request reports