Update button icon

What does this MR do?

Updates button to GlButton, per #229327 (closed)

Screenshots

Current default and hover	default	New hover

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation (if required)
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Availability and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• Tested in all supported browsers
• Informed Infrastructure department of a default or new setting change, if applicable per definition of done

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team

Closes #229327 (closed)

added component:button frontend pajamasintegrate labels

	10 Warnings
	818484a9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	55aa173d: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	3f7f4924: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	44cc1e4e: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	7e410696: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	7a828915: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	41276da1: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	This merge request includes more than 10 commits. Each commit should meet the following criteria: Have a well-written commit message. Has all tests passing when used on its own (e.g. when using git checkout SHA). Can be reverted on its own without also requiring the revert of commit that came before it. Is small enough that it can be reviewed in isolation in under 30 minutes or so. If this merge request contains commits that do not meet this criteria and/or contains intermediate work, please rebase these commits into a smaller number of commits or split this merge request into multiple smaller merge requests.
	This MR has a Changelog file outside ee/, but code changes in ee/. Consider moving the Changelog file into ee/.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the tooling, ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

Category	Reviewer	Maintainer
frontend	Michael Lunøe (@mlunoe) (UTC+2, 6 hours ahead of @kmann)	Vitaly Slobodin (@vitallium) (UTC+3, 7 hours ahead of @kmann)

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in issue #229327 (closed)

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 1f89ccc1 and 46b5dbb8

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
mainChunk	1.9 MB	1.84 MB	-61.16 KB	-3.1 %
average	2.9 MB	2.84 MB	-54.14 KB	-1.8 %

Significant Growth: 13

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.groups.group_members	527.39 KB	574.94 KB	+47.55 KB	9.0 %
pages.groups.usage_quotas	650.04 KB	683.97 KB	+33.93 KB	5.2 %
pages.profiles.usage_quotas	812.47 KB	846.4 KB	+33.93 KB	4.2 %
pages.profiles.show	771.6 KB	789.32 KB	+17.72 KB	2.3 %
pages.snippets.show	855.06 KB	872.78 KB	+17.72 KB	2.1 %
pages.groups.merge_requests	805.03 KB	821.61 KB	+16.57 KB	2.1 %
pages.dashboard.milestones.show	46.69 KB	55.73 KB	+9.04 KB	19.4 %
pages.admin.abuse_reports	150.47 KB	156.45 KB	+5.98 KB	4.0 %
pages.admin.groups.show	250.04 KB	256.02 KB	+5.98 KB	2.4 %
pages.admin.runners	242.54 KB	248.52 KB	+5.98 KB	2.5 %

The table above is limited to 10 entries. Please look at the full report for more details

Significant Reduction: 2

Expand

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
pages.projects.commit.pipelines	419.11 KB	405.6 KB	-13.51 KB	-3.2 %
pages.projects.pipelines.index	602.04 KB	588.53 KB	-13.51 KB	-2.2 %

---

Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.

Please consider pinging someone from the FE Foundations (@justin_ho, @leipert or @mikegreiling) for review, if you are unsure about the size increase.

Note: We do not have exact data for 1f89ccc1. So we have used data from: 864c7a2c.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by Danger

added 1 commit

• 0681ed95 - Update prettier yarn file

Compare with previous version

added typemaintenance label

added typefeature label

assigned to @jmandell

mentioned in issue #219840 (closed)

@jeldergl Here is one more for you, if you have capacity to help out

assigned to @jeldergl

Is there a project I can view in GDK that has licenses set up? None of the projects I have locally use it so I’m not able to see the UI for this.

added 1 commit

• 8836843f - Proper formatting for icon-only button

Compare with previous version

assigned to @kmann and unassigned @jmandell

added 3547 commits

• 8836843f...d667c0b4 - 3542 commits from branch master
• 0bbea5c4 - Update button icon
• 7e410696 - Resolve conflict
• 25a543cc - Proper formatting for icon-only button
• 44cc1e4e - Resolve conflict
• 3f7f4924 - Resolve conflict

Compare with previous version

added 1 commit

• b85d133d - Add tooltip import

Compare with previous version

added 1 commit

• 6ac577a2 - Fixed icon spacing

Compare with previous version

changed the description

added 1 commit

• 3703bdf2 - Fix tests and add tooltip content

Compare with previous version

approved this merge request

unassigned @jeldergl

added 1 commit

• fbe04d3a - Add change log

Compare with previous version

resolved all threads

@markrian hello! Do you have capacity to review this one?

unmarked as a Work In Progress

assigned to @jivanvl

mentioned in merge request !42075 (merged)

unassigned @jivanvl

added 1094 commits

• fbe04d3a...ba0e97d8 - 1085 commits from branch master
• 042c1d0f - Update button icon
• 55aa173d - Resolve conflict
• d524c5b6 - Proper formatting for icon-only button
• 818484a9 - Resolve conflict
• 3f28172b - Add tooltip import
• bda22dd4 - Fixed icon spacing
• 343c27ec - Fix tests and add tooltip content
• a24a5d6a - Add change log
• a1cf8cb9 - Resolve merge conflict

Compare with previous version

added 1 commit

• b10ab477 - Remove author from log

Compare with previous version

changed milestone to %13.5

added 1 commit

• 3e70d414 - Fix spacing error log

Compare with previous version

added 1 commit

• 46b5dbb8 - Fix spacing error log

Compare with previous version

resolved all threads

approved this merge request

Thanks @kmann this looks good to me! I went ahead and did a quick fix, hopefully this should pass

enabled an automatic merge when the pipeline for 1181e734 succeeds

@jivanvl looks like the tests passed, but held up by a warning. Looks ready to merge though

resolved all threads

merged

mentioned in commit 21dfdd32

mentioned in commit 28f2ccee

added workflowstaging label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.

added published label

This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.

---

This comment is generated automatically using the Release Tools project.