Resolve "Remove webpack-rails gem"
What does this MR do?
Removes the long-deprecated webpack-rails
gem and incorporates the few remaining components that we rely on directly into the gitlab codebase.
The only code that was still used from this library included a very simple rake task, and a few methods which help us read and parse the webpack manifest.json
file. All of the other logic was overridden and incorporated into GitLab long ago.
Moving this into our codebase will allow us to eventually rewrite the webpack-dev-server
integration to utilize unix file sockets and address issues like https://gitlab.com/gitlab-org/gitlab/-/issues/247049 and #213130 (closed)
Screenshots
N/A
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #34092 (closed)