Skip to content

Resolve "Remove webpack-rails gem"

Mike Greiling requested to merge 34092-remove-webpack-rails-gem into master

What does this MR do?

Removes the long-deprecated webpack-rails gem and incorporates the few remaining components that we rely on directly into the gitlab codebase.

The only code that was still used from this library included a very simple rake task, and a few methods which help us read and parse the webpack manifest.json file. All of the other logic was overridden and incorporated into GitLab long ago.

Moving this into our codebase will allow us to eventually rewrite the webpack-dev-server integration to utilize unix file sockets and address issues like https://gitlab.com/gitlab-org/gitlab/-/issues/247049 and #213130 (closed)

Screenshots

N/A

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #34092 (closed)

Edited by Mike Greiling

Merge request reports