Skip to content

WIP: Refactor OmniauthCallbacksController to remove duplication

James Edwards-Jones requested to merge jej/refactor-omniauth-controller into master

What does this MR do?

Begin refactoring OmniauthCallbacksController, first by introducing case;when statements to replace duplicated code. Next we can probably replace those with new objects.

Why was this MR needed?

Much duplication.

I'll be adding a new :per_group_saml provider with different logic in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4076 and didn't want to duplicate things yet again.

Acceptance criteria

Related

Merge request reports