Skip to content

Refactor commit information to use axios

What does this MR do?

Refactor commit information to use axios instead of jquery .load.

This change changes the way the commit information box is rendered to avoid code duplication and replacing jquery .load() with Axios.

Test this:

Visit the commit page of your project, click on both tabs (Changes and Pipelines)

This MR touches a couple of legacy files (with no tests), so we need some extra care during review.

Screenshots

This is the component under refactor:

Screen_Shot_2020-09-15_at_4.40.33_PM

An extra smoke test, everything is loading 🎉

2020-09-15_16.27.30

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #32660 (closed)

Edited by Miguel Rincon

Merge request reports