requested to merge 235756-ssh-public-keys-no-longer-public-accessible into master
What does this MR do?
- Reverts !35507 (merged).
!35507 (merged) moved
getSSH keys from keys controller to user controller to reduce confusion between gpg keys and ssh keys, but since the User controller goes through the permission policy to read user, a non-logged in user would get redirected to the log in page if they tried to go to
- More in-depth discussion here: #235756 (comment 396156444)
- !35507 (merged) moved
- Adds RSpecs to
keys_controller_spec.rbto ensure that when signed out, user's SSH public keys are still
% curl http://127.0.0.1:3000/root.keys ssh-rsa AAAA...gJw0= Administrator (127.0.0.1)%
Does this MR meet the acceptance criteria?
Documentation (if required)
Code review guidelines
Merge request performance guidelines
Separation of EE specific content
Availability and Testing
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Tested in all supported browsers
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
Label as security and @ mention
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team
Closes #235756 (closed)