Skip to content

Migrate almost all existing development feature flags (RUN AS-IF-FOSS)

Kamil Trzciński requested to merge migrate-all-existing-development-feature-flags into master

What does this MR do?

This is part of the #241771 (closed).

This does

  1. Migrate existing feature flags
  2. Currently, only development type feature flags are covered
  3. Other types will be done at later point
  4. Not all development are covered, the feature flags that are undefined will be covered in a follow-up MR. A few examples of such flags can be found here: !31610 (closed)

Impact

It ensures that the migrated feature flags are used consistently as described in: https://docs.gitlab.com/ee/development/feature_flags/development.html#feature-flag-definition-and-validation

This process is meant to ensure consistent feature flag usage in the codebase. All feature flags must:

  • Be known. Only use feature flags that are explicitly defined
  • Not be defined twice. They have to be defined either in FOSS or EE, but not both
  • Use a valid and consistent type: across all invocations.
  • Use the same default_enabled: across all invocation
  • Have an owner: this is currently not covered

Outcome

$ find config/feature_flags/development -name '*.yml' | wc -l                  
257
$ find ee/config/feature_flags/development -name '*.yml' | wc -l
94

Does this MR meet the acceptance criteria?

Conformity

Edited by Kamil Trzciński

Merge request reports