Skip to content

Fix the paginated_notes feature flag for groups

Nick Thomas requested to merge 209784-fix-paginated-notes-feature-flag into master

What does this MR do?

Right now, the paginated_notes feature flag has no effect on epics because Epics::NotesController#project unconditionally returns nil.

Since the epics is exposed as noteable, we can use noteable#resource_parent to get a group or project as required.

Since this related to FF implementation, and the FF is not documented yet, I don't think it needs a changelog. The flag is currently off on GitLab.com.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Part of #209784 (closed)

Edited by Nick Thomas

Merge request reports