Skip to content

ES reindexing: add confirmation popup and change color scheme

Dmitry Gruzd requested to merge change-es-reindexing-color-scheme into master

What does this MR do?

I realized that users might accidentely click Trigger cluster reindexing when they want to save changes since Save changes and Trigger cluster reindexing are both green and we don't have a confirmation popup.

This MR changes the color scheme and adds a popup with Are you sure you want to reindex? message.

Screenshots

Screenshots are from /admin/application_settings/general#js-elasticsearch-settings

Before

Screenshot_2020-09-14_at_11.51.44

After

Screenshot_2020-09-14_at_11.51.23

Screenshot_2020-09-14_at_12.04.25

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dmitry Gruzd

Merge request reports