Replace button GlButton
What does this MR do?
Updating button, per: #229316 (closed)
Screenshots
Current | WIP: :hover display |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #229316 (closed)
Merge request reports
Activity
changed milestone to %13.5
- Resolved by Kyle Mann
Hello @ealcantara, updated the button and import on this. Wasn't able to fix the styling issue. Could you review if have time? What am I missing here?
13 Warnings e0188ad7: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. b7b07e90: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 08846611: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 08846611: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. bc679533: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 7a828915: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 86f6d6f4: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines. 86f6d6f4: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 41276da1: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. c6d00c85: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 121d10cb: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. 4be72478: Commits that change 30 or more lines across at least 3 files must describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request includes more than 10 commits. Each commit should meet the following criteria: - Have a well-written commit message.
- Has all tests passing when used on its own (e.g. when using git checkout SHA).
- Can be reverted on its own without also requiring the revert of commit that came before it.
- Is small enough that it can be reviewed in isolation in under 30 minutes or so.
If this merge request contains commits that do not meet this criteria and/or contains intermediate work, please rebase these commits into a smaller number of commits or split this merge request into multiple smaller merge requests.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Roman Kuba ( @rkuba
) (UTC+1, same timezone as@kmann
)Phil Hughes ( @iamphill
) (UTC+0, 1 hour behind@kmann
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits cfc6a8bf and e0188ad7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.01 MB 3.01 MB - 0.0 % mainChunk 1.87 MB 1.87 MB - 0.0 %
Note: We do not have exact data for cfc6a8bf. So we have used data from: 3803fff4.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by 🤖 GitLab Bot 🤖assigned to @kmann
- Resolved by Taurie Davis
mentioned in merge request !42065 (merged)
assigned to @jareko
added typemaintenance label
added typefeature label
assigned to @jj-ramirez and unassigned @jareko
unassigned @jj-ramirez
mentioned in merge request !42323 (merged)
added 293 commits
-
bc679533...ced482c7 - 291 commits from branch
master
- 8fe205ca - Replace button GlButton
- e42ceabd - Fix test specs
-
bc679533...ced482c7 - 291 commits from branch
mentioned in issue #229327 (closed)
mentioned in issue #219840 (closed)
@jeldergl Do you mind helping with this MR?
assigned to @jeldergl
- Resolved by Taurie Davis
@kmann when I’m viewing this locally, this is what I see…
unassigned @jmandell
assigned to @kmann
- Resolved by Mark Florian
@ealcantara hello
, I'm having trouble with this MR - looks like some merge conflicts. Do you have capacity to assist? I'm not sure how to sort this out.Here's where I'm at: I've been OOO and checked out the branch and received this message:EDIT: deleted message as the the issue was sorted out with
yarn
updateEdited by Kyle Mann
added 10 commits
- 162d34f6 - Replace button GlButton
- d42c1c91 - Fix icon display
- 81403b29 - Update button in spec
- 718eb7ea - Update button prettier
- 53d2eac2 - Replace button GlButton
- 7c0446c8 - Fix icon display
- 5daa110a - Update button in spec
- c6954fb0 - Update button prettier
- bc679533 - Rebase
- 08846611 - Resolve conflict
Toggle commit listassigned to @tauriedavis and unassigned @jeldergl
changed milestone to %13.6
added missed:13.5 label
added 1 commit
- 4855c5a4 - Correct styling of loading button on mr widget extension
mentioned in issue #271597
added 1 commit
- 07ef8bff - Correct styling of loading button on mr widget extension
added 1 commit
- 6795aa24 - Correct styling of loading button on mr widget extension
unassigned @tauriedavis
- Resolved by Kyle Mann
@markrian do you have capacity to review this? It's a button update for the carrot seen in the MR approval list dropdown. There are some styling updates to fix the focus view issues: !42075 (comment 435233353). Looking good so far, but I tried to sort out the pipeline issues and was unable to. wdyt about the above changes and could fix the pipeline?
assigned to @markrian
mentioned in issue gitlab-ui#1045 (closed)
added 6992 commits
-
6795aa24...3679ee81 - 6990 commits from branch
master
- b830294e - Merge branch 'master' into...
- 6fb7783e - Fix specs and prefer util classes over new CSS
-
6795aa24...3679ee81 - 6990 commits from branch
- Resolved by Mark Florian
Thanks @kmann; I've pushed some fixes/changed the approach regarding the styling.
Once you've confirmed this is rendering in the expected way for you, please reassign back to me and I'll set MWPS!
Back to you for now
unassigned @markrian
assigned to @markrian
marked the checklist item Changelog entry as completed
marked the checklist item Separation of EE specific content as completed
enabled an automatic merge when the pipeline for ca3c99fc succeeds
enabled an automatic merge when the pipeline for ca3c99fc succeeds
mentioned in commit e071343a
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #229316 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
removed typefeature label