Skip to content
Snippets Groups Projects

Replace button GlButton

All threads resolved!

What does this MR do?

Updating button, per: #229316 (closed)

Screenshots

Current WIP: :hover display
Screen_Shot_2020-09-11_at_12.53.16_PM Screen_Shot_2020-09-14_at_5.59.55_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #229316 (closed)

Edited by Mark Florian

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Contributor

    @markrian do you have capacity to review this? It's a button update for the carrot seen in the MR approval list dropdown. There are some styling updates to fix the focus view issues: !42075 (comment 435233353). Looking good so far, but I tried to sort out the pipeline issues and was unable to. wdyt about the above changes and could fix the pipeline?

  • assigned to @markrian

  • Kyle Mann changed the description

    changed the description

  • Mark Florian added 6992 commits

    added 6992 commits

    Compare with previous version

  • Mark Florian unmarked as a Work In Progress

    unmarked as a Work In Progress

    • Resolved by Mark Florian

      Thanks @kmann; I've pushed some fixes/changed the approach regarding the styling.

      Once you've confirmed this is rendering in the expected way for you, please reassign back to me and I'll set MWPS!

      Back to you for now :ping_pong:

  • assigned to @markrian

  • Mark Florian added 1 commit

    added 1 commit

    Compare with previous version

  • Mark Florian marked the checklist item Changelog entry as completed

    marked the checklist item Changelog entry as completed

  • Mark Florian marked the checklist item Separation of EE specific content as completed

    marked the checklist item Separation of EE specific content as completed

  • Mark Florian resolved all threads

    resolved all threads

  • Mark Florian approved this merge request

    approved this merge request

  • Mark Florian enabled an automatic merge when the pipeline for ca3c99fc succeeds

    enabled an automatic merge when the pipeline for ca3c99fc succeeds

  • Mark Florian canceled the automatic merge

    canceled the automatic merge

  • Mark Florian enabled an automatic merge when the pipeline for ca3c99fc succeeds

    enabled an automatic merge when the pipeline for ca3c99fc succeeds

  • merged

  • Mark Florian mentioned in commit e071343a

    mentioned in commit e071343a

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • mentioned in issue #229316 (closed)

  • Please register or sign in to reply
    Loading