Skip to content

Treat suggestion lines the same as code lines

Sean Arnold requested to merge sarnold-fix-suggestion-line-copy into master

What does this MR do?

This fixes the issue where copying code from a suggestion would erroneously copy line numbers and add in extra new lines.

Example - when copying the new content in the following suggestion

Screen_Shot_2020-09-11_at_3.50.21_PM

Before:

# Other files and folders testing change
    
   
    8
   new line
    
   
    9
   second new line
    
   
    10
   
    
   
    11
      Indented line

After:

# Other files and folders testing change
new line
second new line

   Indented line

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sean Arnold

Merge request reports