Skip to content

Remove Feature Flag License Check RUN AS-IF-FOSS

Jason Goodman requested to merge move-ff-license-to-core into master

What does this MR do?

Remove the license check for feature flags.

This MR makes Feature Flags available in GitLab Enterprise edition with any Starter, Premium, or Ultimate license. Feature Flags are also available in Enterprise Edition without a license. Feature Flags are still not available in GitLab FOSS.

Keep a license check for Feature Flag Related Issues. This feature is available only in Premium and Enterprise.

This is part of moving feature flags to Core.

Issue: #212318 (closed)

Screenshots

GitLab Enterprise Edition with an Ultimate or Premium License

  • The Feature Flags menu exists:

Screen_Shot_2020-09-14_at_5.25.54_PM

  • The index page exists:

Screen_Shot_2020-09-14_at_5.26.57_PM

  • The feature flag edit page displays the linked issues widget:

Screen_Shot_2020-09-14_at_5.22.33_PM

  • Creating, deleting, and editing flags works. Unleash clients can request flags.

GitLab Enterprise Edition with Starter or No License

  • The Feature Flags menu exists:

Screen_Shot_2020-09-14_at_6.02.32_PM

  • The index page exists:

Screen_Shot_2020-09-14_at_6.03.17_PM

  • The feature flag edit page does not display the linked issues widget:

Screen_Shot_2020-09-14_at_6.04.09_PM

  • Creating, deleting, and editing flags works. Unleash clients can request flags.

GitLab FOSS

  • The Feature Flags menu does not exist:

Screen_Shot_2020-09-14_at_5.41.04_PM

  • The index page does not exist:

Screen_Shot_2020-09-14_at_5.49.19_PM

  • The feature flag edit page does not exist:

Screen_Shot_2020-09-14_at_5.49.56_PM

  • Creating, deleting, and editing flags does not work. Unleash clients cannot request flags. They receive a 404.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jason Goodman

Merge request reports