Skip to content

Improve reusability in On-demand DAST Scans form

What does this MR do?

In !41922 (merged), we have created profile selector components that abstract the profile selectors in the On-demand scans form. This MR is the second and last step of this code refactor which involves actually using those new components, which lets us drop a bunch of duplicated code.

This also cleans up related specs by removing some computed props tests in favor of implicit UI tests and other minor improvements.

Screenshots

The only visible change is the cards' titles that have been updated to align with the latests designs.

Before After
Screen_Shot_2020-09-29_at_10.43.50_AM Screen_Shot_2020-09-29_at_10.44.38_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Paul Gascou-Vaillancourt

Merge request reports