Fix SAST Config GraphQL mutation
What does this MR do?
Fixes bug where we were passing along the supplied defaultValue of variables instead of value to Security::CiConfiguration::SastCreateService. #227575 (closed) is currently blocked by this bug.
Please note that this code will be removed/refactored as soon as the frontend can implement this GraphQL mutation, but they can't do that until it works correctly. Also note that no tests were added or updated. This is because the method in question is not easily tested here, and more importantly, will be moved to another class (probably ee/lib/security/ci_configuration/sast_build_actions.rb) where it will be much more easily tested.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team