Skip to content

Add static translation check on ivars

Adam Hegyi requested to merge 214635-static-translation-definitions-v2 into master

What does this MR do?

This MR extends the StaticTranslationDefinition to prevent memoizing translations in class methods. This is usually done for caching purposes, however caching them on the instance level will make the I18n strings static, and won't respect the user's current language.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Closes #214635 (closed)

Edited by Peter Leitzen

Merge request reports