Skip to content

Draft: Resolve "N+1 SQL queries in Projects::MergeRequestsController#index"

Mark Chao requested to merge 198028-mark into master

What does this MR do?

This is a pseudo fix for N+1 issue. It should not be merged.

Run bundle exec rspec ee/spec/controllers/projects/merge_requests_controller_spec.rb:62 to output queries related to the index action. It would print total number of queries on the top.

When 1 MR exists, there are 173 queries. When 20 MR exists, there are 230 queries.

My fix reduce the count back to 191.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #198028 (closed)

Edited by Mark Chao

Merge request reports