Skip to content

Column drop `remove_after` to be the release date of the M+2 milestone

Alper Akgun requested to merge aa-column-drop-remove-after-release-date into master

What does this MR do?

Column drop remove_after to be the release date

Followup from !41556 (comment 409310669)

@mayra-cabrera :We normally use the end date of the remove_with milestone, since 13.6 is shipped on November 22nd, could we update this to use 2020-11-22? Also do we have a follow-up issue for the post-migration and to remove this ignore_column? If not, could we please create it?

  ignore_column :namespace_storage_size_limit, remove_with: '13.5', remove_after: '2020-09-22'
  ignore_column :instance_statistics_visibility_private, remove_with: '13.6', remove_after: '2020-10-22'
  ignore_column :snowplow_iglu_registry_url, remove_with: '13.6', remove_after: '2020-10-22'

3-release column drop it seems like we need to use the end date of the milestone. So above for 13.5 it had to be 2020-10-22 and for 13.6 it hat to be 2020-11-22

In the docs we have 12.7 as an example which was released on 2020-01-22 https://docs.gitlab.com/ee/development/what_requires_downtime.html#step-1-ignoring-the-column-release-m ignore_column :updated_at, remove_with: '12.7', remove_after: '2019-12-22'

Does this MR meet the acceptance criteria?

Conformity

Edited by Mayra Cabrera

Merge request reports