Skip to content

Remove bootrap alert from gcp offer

Alexander Turinske requested to merge 233660-remove-bootstrap-alert-gcp into master

What does this MR do?

Remove bootstrap alert from gcp offer

To Reproduce

Update app/helpers/clusters_helper.rb so

  def render_gcp_signup_offer
    #return if Gitlab::CurrentSettings.current_application_settings.hide_third_party_offers?
    #return unless show_gcp_signup_offer?
     return if show_gcp_signup_offer?

    content_tag :section, class: 'no-animate expanded' do
      render 'clusters/clusters/gcp_signup_offer_banner'
    end
  end

Navigate to Admin -> Kubernetes

Screenshots

Before After
old_gcp image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #233660 (closed)

Related to gitlab-com/www-gitlab-com#8498 (closed)

Edited by Alexander Turinske

Merge request reports