Skip to content

Use CounterAttribute for build_artifacts_size

Fabio Pitino requested to merge build-artifacts-size-as-counter-attribute into master

What does this MR do?

Related to #238534 (closed)

In this MR we are updating build_artifacts_size in ProjectStatistics using the new CounterAttribute concern which updates project statistics using Redis to accumulate frequent increments while flushing them async to the database.

Why are we doing this?

We implemented !35878 (merged) to enable counters that were affected by statement timeout issues to be able to batch increments and then flush those increments asynchronously so we don't need to perform a db query frequently.

Feature flag

This change is still guarded behind the feature flag efficient_counter_attribute which is disabled by default.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Pitino

Merge request reports