Skip to content

Remove `promo_` implicit licensed feature flags

Kamil Trzciński requested to merge remove-promo-feature-flags into master

What does this MR do?

Related to: #246758 (closed)

This is added for a purpose that once we start tracking all licensed feature flags this effectively doubles amount of YAML-definitions that has to be created

This reverts changes introduced by !27412 (merged), the promo_ feature flag check.

The intent of promo_<licensed_feature> was to allow enabling feature for everyone skipping license check. This does introduce a number of implicit licensed feature flags connected with that.

According to https://gitlab.com/gitlab-com/gl-infra/feature-flag-log/-/issues?scope=all&utf8=%E2%9C%93&state=all&search=promo_ we did not ever use this promo_ check. To reduce a complexity of amount of feature flags present in source code we should remove it and consider adding another method if this deems to be useful.

Does this MR meet the acceptance criteria?

Conformity

Edited by Kamil Trzciński

Merge request reports