Skip to content

Fixed image discussions not showing on the changes tab

What does this MR do?

Fixes image discussions not getting assigned to images in the changes tab correctly. This was caused by a simple falsey check instead of a length check as every file will always have an empty array for diff lines.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #225922 (closed)

Merge request reports