Skip to content

Fix always visible sidebar TODO button spinner

What does this MR do?

Fixes a regression introduced in !41132 (merged) that makes the loading spinner of the "Add TODO" button in the sidebar to be always visible (see screenshots section). See more information in #246502 (closed) as well.

note: I spent considerable time verifying what parts of the sidebar are affected by the styles removed on this Merge Request, and I can confirm that those styles only affect the loading icon in the sidebar’s TODO button.

Screenshots

Before After
Screen_Shot_2020-09-07_at_9.07.42_AM Screen_Shot_2020-09-07_at_9.06.57_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #246502 (closed)

Edited by Enrique Alcántara

Merge request reports