Skip to content

Add filtering by activity (has_resolution, has_issues) to Vulnerability

What does this MR do?

Related to #233349 (closed)

This MR adds new filters to GraphQL API for Vulnerabilities that allows to filter vulnerabilities with created/related issues and vulnerabilities with and without resolution.

Queries

multiple filters

SELECT "vulnerabilities".*
FROM "vulnerabilities"
WHERE "vulnerabilities"."resolved_on_default_branch" = FALSE
  AND (
    EXISTS (
      SELECT 1
      FROM "vulnerability_issue_links"
      WHERE "vulnerability_issue_links"."vulnerability_id" = "vulnerabilities"."id"
    )
  )
  AND "vulnerabilities"."state" IN (1, 4)
  AND "vulnerabilities"."severity" = 7
ORDER BY "vulnerabilities"."severity" ASC,
  "vulnerabilities"."id" DESC

https://explain.depesz.com/s/XZSRW (~25ms)

with_issues(true)

SELECT "vulnerabilities".*
FROM "vulnerabilities"
WHERE (
    EXISTS (
      SELECT 1
      FROM "vulnerability_issue_links"
      WHERE "vulnerability_issue_links"."vulnerability_id" = "vulnerabilities"."id"
    )
  )

https://explain.depesz.com/s/tyXt (~12ms)

with_issues(false)

SELECT "vulnerabilities".*
FROM "vulnerabilities"
WHERE (
    NOT EXISTS (
      SELECT 1
      FROM "vulnerability_issue_links"
      WHERE "vulnerability_issue_links"."vulnerability_id" = "vulnerabilities"."id"
    )
  )

https://explain.depesz.com/s/64tY (~17ms)

with_resolution(true)

SELECT "vulnerabilities".*
FROM "vulnerabilities"
WHERE "vulnerabilities"."resolved_on_default_branch" = TRUE

https://explain.depesz.com/s/xL7Q (~11ms)

with_resolution(false)

SELECT "vulnerabilities".*
FROM "vulnerabilities"
WHERE "vulnerabilities"."resolved_on_default_branch" = FALSE

https://explain.depesz.com/s/6WrE (~10ms)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alan (Maciej) Paruszewski

Merge request reports