Skip to content

Resolve alert when end_time is given

Sean Arnold requested to merge 13402-close-alert-when-end-time-given into master

What does this MR do?

This resolves an existing Alert when we receive another call to the endpoint with the end_time set. We check if the new payload matches a fingerprint of an existing alert, and if so we resolve the alert.

If no fingerprint matches, then we ignore the occurrence of that alert.

This matches the behaviour for what we do with Prometheus Alerts, in ProcessPrometheusAlertService.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #13402 (closed) and #217049 (closed)

Edited by Sean Arnold

Merge request reports