Part 2: Add todo-related queries/resolvers to Design Management
What does this MR do?
This MR is the last major part towards #198439 (closed).
- query for the recently-support
currentUserTodos - add cache_update logic for creating and deleting designs
It is still behind the feature flag design_management_todo_button.
Why no tests?
We will follow-up with tests in #247444 (closed).
The global To-Do counter doesn't update - what's up with that?
This will come in a future MR (see !40222 (comment 408495333)) for context)
Demo
Original issue: #198439 (closed)
Feature flag rollout issue: #245074 (closed)
| Part | MR |
|---|---|
| 1. Create shared todo button | !39931 (merged) |
2. Add vue_shared/todo_button.vue to Design Management (behind feature flag) |
!39935 (merged) |
| 3. Part 1: Add necessary queries and resolvers to Design Management's Apollo client | !40222 (merged) |
| 4. Part 2: Add necessary queries and resolvers to Design Management's Apollo client |
|
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk