Fix error handling for DAST on-demand profile library
requested to merge 233453-dast-site-profile-library-implementation-iteration-1-fix-error-handling into master
What does this MR do?
It fixes an issue on the DAST on-demand scans page that prevents fetch-errors due to network issues or server errors to show up and also changes them from being handled globally to be scoped to each profile type.
How to test this?
- Enable feature flag:
echo "Feature.enable(:security_on_demand_scans_scanner_profiles)" | spring rails c- Navigate to on-demand scanner profile page:
http://localhost:3000/{grou}/{project}/-/on_demand_scans/profiles e.g: http://localhost:3000/h5bp/html5-boilerplate/-/on_demand_scans/profiles
- Wait until the page has loaded, then enable "offline" mode in your browser's developer tools and click "load more" button
Screenshots
| before | after |
|---|---|
| before | after |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry - currently behind feature flag
-
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #233453 (closed)
Edited by David Pisek