Skip to content

WIP: Fix issueMoveList mutation to repositions issues correctly

What does this MR do?

Related to #246162 (closed)

The following mutation should behave the same way as repositioning an issue within a board list via web but it doesn't:

mutation{
  issueMoveList(input: {projectPath: "test-group-1/test-project-1", iid: "3", boardId: "gid://gitlab/Board/15", fromListId: 34, toListId: 36, moveAfterId: 476, moveBeforeId: null}) {
    issue {
      iid,
      relativePosition
    }
  }
}

These changes interchange the use of moveBeforeId with moveAfterId.

Screenshots

Before these changes

Move C before A Move C between A and B Move C after B
Screen_Shot_2020-09-06_at_15.44.14 Screen_Shot_2020-09-06_at_15.38.07 Screen_Shot_2020-09-06_at_15.41.05

After these changes

Move C before A Move C between A and B Move C after B
Screen_Shot_2020-09-06_at_15.11.39 Screen_Shot_2020-09-06_at_15.04.49 Screen_Shot_2020-09-06_at_15.16.15

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #246162 (closed)

Closes #246162 (closed)

Merge request reports