Skip to content

WIP: Add link to toggle dark mode

Austin Regnery requested to merge ar-dark-mode-toggle into master

What does this MR do?

Toggle dark mode from anywhere in GitLab! Dark Mode is still in alpha, and as a result I stick to just using Indigo because I don't run into issues. Switching Dark Mode on and off would normally require digging into profile > settings > preferences in order to change it.

Thanks to @davidsawyer for helping me kick off my idea! 🚀

What's left?

  • Create a new API endpoint in either rest / GraphQL
  • Adding a toggle component

Screenshots

Current UX Stretch goal: add a toggle to show state
Dark_mode_toggle Frame_3

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

The solution is still rather half baked. Right now it will toggle between Dark Mode and Indigo, as it is hard coded in javascript. Could definitely use some and refactoring to make it better.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Austin Regnery

Merge request reports