Skip to content

Revert "Merge branch '241468-visibility-level' into 'master'"

Dylan Griffith requested to merge revert-0d665b4a into master

What does this MR do?

This reverts !41014 (merged) which caused a regression creating snippets.

When creating a snippet you cannot see the snippet content after creation. I see the JS console error:

VM9122:1 Uncaught SyntaxError: Unexpected token u in JSON at position 0
    at JSON.parse (<anonymous>)
    at appFactory (index.js?8dc4:26)
    at SnippetShowInit (index.js?8dc4:46)
    at HTMLDocument.eval (snippet_show.js?2fda:16)

which links to this line of code !41014 (diffs)

Closes #245081 (closed) (QA failures on master and staging)

Screenshots

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Anastasia McDonald

Merge request reports