Skip to content

Update the 2FA user check to use timestamps

Catalin Irimie requested to merge cat-time-precision-2fa-ldap into master

What does this MR do?

Fixes problems with time comparisons in the 2FA check when the user model gets reloaded in the original request before the time is saved in the session.

Related to #244638 (closed).

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

/cc @mksionek @dblessing

Edited by Catalin Irimie

Merge request reports