Drop DinD for SAST, DS

Merged Fabien Catteau requested to merge 220540-drop-ds-sast-dind into master

What does this MR do?

Drop Docker-in-Docker (DinD) mode for SAST and Dependency Scanning:

  • remove the variable used to enable the DinD mode
  • change sast and dependency_scanning jobs
    • update the rules so that they're not triggered
    • update the script so that they fail with an explicit error message
    • remove the allow_failure attribute, making sure they do fail when triggered

As a result, it's not possible to change the default value of allow_failure using sast or dependency_scanning. The benefit is that users will be forced to notice the misuse of these jobs.

See #220540 (closed)

Tested with tests/go-modules

Also, tested with apex-salesforce to make sure that the sast job can be overridden. This pipeline fails as expected: https://gitlab.com/gitlab-org/security-products/tests/apex-salesforce/-/pipelines/185136220


Does this MR meet the acceptance criteria?


Availability and Testing


If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports