Skip to content

Replace v-html with v-safe-html in popover.vue

Kev requested to merge KevSlashNull/gitlab:241969-Replace-v-html into master

What does this MR do?

This MR replaces v-html with v-safe-html in app/assets/javascripts/blob/suggest_gitlab_ci_yml/components/popover.vue.

Relates to #241969 (closed).

Steps to test

I'm not sure how to test this properly 😅 What I did to get to the component was:

  1. Create a MR in a project without a pipeline
  2. Go to the code and replace - if should_suggest_gitlab_ci_yml? in app/views/projects/blob/_editor.html.haml with - if not should_suggest_gitlab_ci_yml?
  3. Go to /<group>/<project>/-/new/<branch of the MR>/?file_name=.gitlab-ci.yml&suggest_gitlab_ci_yml=true&mr_path=<path to more>
  4. Check that the popover is rendered correctly.

image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev

Merge request reports