Skip to content

Un-nest sidebar under .context-header div in sec

Alexander Turinske requested to merge 244063-improve-padding into master

What does this MR do?

Un-nest sidebar under .context-header div in sec

  • nesting added unnecessary styling to rest of sidebar instead of just for header

Screenshots

Before After
Screen_Shot_2020-09-02_at_11.28.56_AM Screen_Shot_2020-09-02_at_11.28.08_AM
Screen_Shot_2020-09-02_at_11.28.50_AM Screen_Shot_2020-09-02_at_11.28.15_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #244063 (closed)

Edited by Alexander Turinske

Merge request reports