Stop clearing memoization of `licensed_feature_available` in CORE
What does this MR do?
After moving features form EE to CORE we forgot to remove these memoizations; they don't have any effect in CORE.
Came up during research in #10385 (comment 406121774).
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %13.4
added 1 commit
- 2e185969 - Stop clearing memoization of `licensed_feature_available` in CORE
@seanarnold Do you mind reviewing this MR since you already have context (#10385 (comment 405708403))?Feel free to pass it to
@ck3g
afterwardsassigned to @seanarnold and unassigned @splattael
- Resolved by Vitali Tatarintev
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Nikola Milojevic ( @nmilojevic1
) (UTC+2, same timezone as@splattael
)Rémy Coutable ( @rymai
) (UTC+2, same timezone as@splattael
)If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by 🤖 GitLab Bot 🤖added test label
added sectionops label
assigned to @ck3g and unassigned @seanarnold
enabled an automatic merge when the pipeline for a1b9f158 succeeds
mentioned in commit 12b5376a
added workflowstaging label
mentioned in issue #10385 (closed)
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added typemaintenance label and removed tooling (archive) label