Skip to content
Snippets Groups Projects

Stop clearing memoization of `licensed_feature_available` in CORE

All threads resolved!

What does this MR do?

After moving features form EE to CORE we forgot to remove these memoizations; they don't have any effect in CORE.

Came up during research in #10385 (comment 406121774).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    backend Nikola Milojevic (@nmilojevic1) (UTC+2, same timezone as @splattael) Rémy Coutable (@rymai) (UTC+2, same timezone as @splattael)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by 🤖 GitLab Bot 🤖
  • added test label

  • Sean Arnold approved this merge request

    approved this merge request

  • Sean Arnold assigned to @ck3g and unassigned @seanarnold

    assigned to @ck3g and unassigned @seanarnold

  • Vitali Tatarintev resolved all threads

    resolved all threads

  • Vitali Tatarintev approved this merge request

    approved this merge request

  • Vitali Tatarintev enabled an automatic merge when the pipeline for a1b9f158 succeeds

    enabled an automatic merge when the pipeline for a1b9f158 succeeds

  • mentioned in commit 12b5376a

  • mentioned in issue #10385 (closed)

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.


    :robot: This comment is generated automatically using the Release Tools project.

  • This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.


    :robot: This comment is generated automatically using the Release Tools project.

  • added typemaintenance label and removed tooling (archive) label

  • Please register or sign in to reply
    Loading