Skip to content

Replace v-html with v-safe-html in noteable_note.vue

Kev requested to merge KevSlashNull/gitlab:241933-Replace-v-html into master

What does this MR do?

This replaces v-html with v-safe-html in app/assets/javascripts/notes/components/noteable_note.vue.

Relates to #241933 (closed).

Steps to test/reproduce

  1. Create a new merge request.
  2. Add a commit to the merge request.
  3. Comment on a line in that commit.
  4. Check that the commit hash is displayed properly and links to the correct URL.

image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev

Merge request reports