Skip to content

Replace v-html with v-safe-html in delete_project_modal.vue

Kev requested to merge KevSlashNull/gitlab:241897-Replace-v-html into master

What does this MR do?

This replaces v-html with v-safe-html in app/assets/javascripts/pages/admin/projects/index/components/delete_project_modal.vue.

Relates to #241897 (closed).

Steps to test/replicate

  1. Go to any project's general settings.
  2. Click on Delete Project to open the delete_project_modal component.
  3. The modal should show the red alert box and "please type the following..." (as they were using v-html before and are rendered as raw HTML).

image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev

Merge request reports