Skip to content

Replace v-html with v-safe-html in history_comment.vue

Kev requested to merge KevSlashNull/gitlab:241891-Replace-v-html into master

What does this MR do?

This MR replaces v-html with v-safe-html in ee/app/assets/javascripts/vulnerabilities/components/history_comment.vue. Relates to #241891 (closed).

Steps to Test/Replicate

  1. Go to a security dashboard (instance, group, or project) with vulnerabilities
  2. Open a vulnerability
  3. Confirm, dismiss or resolve the vulnerability
  4. Add a comment (the component containing the comment is the history_comment component). It should not allow unsafe HTML to be rendered.

image image

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev

Merge request reports