Skip to content

Fixes diff view cookie being set on wrong endpoint

Phil Hughes requested to merge ph/fixDiffViewCookieBeingSetIncorrectly into master

What does this MR do?

Fixes the diff view cookie being set incorrectly when the unified diff lines feature flag is enabled. Instead of setting the diff cookie on the batch/metadata endpoint (which with unified diff lines always gets set as inline) this changes it to only be set on the merge request show action.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports