Skip to content

Prevent duplicate system notes when moving issues

Heinrich Lee Yu requested to merge fix-system-notes-when-moving-issues into master

What does this MR do?

Related to #229147 (comment 405258000)

When moving issues, we use the Issues::CreateService to create the new issue. This has a side-effect of creating system notes for the attributes that are already set. Like weight and milestone.

We also copy these notes and events from the old issue so we end up with duplicates.

This MR fixes the problem by passing an argument to skip system note creation when creating this cloned issue.

This also reverts part of d0e4810a which tries to fix this problem for weights by skipping system notes altogether during creation. This is a problem because when we're just creating a new issue, we should have the system note / event.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Mayra Cabrera

Merge request reports