Resolve "Multi-project pipelines in Web IDE lead to 404"
What does this MR do?
This MR changes the serialized job so that it doesn't contain a link to the non-existent details page and uses the presence of the detail page path to decide whether to show the link to this job in Web IDE (build job) or hide it (bridge job). We are hiding bridge job links because bridge jobs don't have their own detail page (i.e. /:group/:project/-/jobs/:job_id
).
The serialized JobEntry
is only used in Web IDE (I wasn't able to find any other usages).
Screenshots
before | after |
---|---|
![]() |
![]() |
multi is a bridge job triggering pipeline in a different project, the #745 link leads to 404 page |
multi doesn't have a detail link |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Part of #216480 (closed)
Edited by Tomas Vik