Use applogger in config/*
What does this MR do?
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
- Resolved by Peter Leitzen
@splattael PTAL
added Community contribution Hackathon labels
added typemaintenance + 1 deleted label
added typefeature label
added Engineering Productivity label and removed 1 deleted label
mentioned in merge request !41052 (merged)
added 984 commits
-
5d134474...c78115d4 - 981 commits from branch
gitlab-org:master
- 77464b44 - Use applogger in config/*
- 290bad8e - Add changelog
- df5af008 - Use rails logger in api.rb for missing add method
Toggle commit list-
5d134474...c78115d4 - 981 commits from branch
- Resolved by Peter Leitzen
@splattael - I am not sure why this spec fails?
Can you please help a little?
EDIT Adding the link: https://gitlab.com/raju249/gitlab/-/jobs/721893308
Edited by Rajendra Kadam
added 529 commits
-
cf4e02e1...0a8ed206 - 525 commits from branch
gitlab-org:master
- f27ae5e8 - Use applogger in config/*
- 9414a6de - Add changelog
- c466850e - Use rails logger in api.rb for missing add method
- b1400f46 - Fix changelog type
Toggle commit list-
cf4e02e1...0a8ed206 - 525 commits from branch
marked the checklist item Changelog entry as completed
- Resolved by Peter Leitzen
added devopsmonitor grouprespond sectionops labels
assigned to @splattael and @raju249
enabled an automatic merge when the pipeline for 12835432 succeeds
changed milestone to %13.4
added backend label
1 Warning 9414a6de: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer backend Zamir Martins Filho ( @zmartins
) (UTC-6)James Fargher ( @proglottis
) (UTC+12)If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit 5b0d288d
added workflowstaging label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.added published label
This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.
This comment is generated automatically using the Release Tools project.removed typefeature label