Skip to content
Snippets Groups Projects

Use applogger in config/*

Merged Rajendra Kadam requested to merge raju249/gitlab:app-logger-2 into master
All threads resolved!

What does this MR do?

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Peter Leitzen approved this merge request

    approved this merge request

  • Peter Leitzen resolved all threads

    resolved all threads

  • Peter Leitzen enabled an automatic merge when the pipeline for 12835432 succeeds

    enabled an automatic merge when the pipeline for 12835432 succeeds

  • Peter Leitzen changed milestone to %13.4

    changed milestone to %13.4

  • 1 Warning
    :warning: 9414a6de: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited, or the chosen person is unavailable.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    backend Zamir Martins Filho (@zmartins) (UTC-6) James Fargher (@proglottis) (UTC+12)

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • merged

  • Peter Leitzen mentioned in commit 5b0d288d

    mentioned in commit 5b0d288d

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • This merge request has been deployed to the pre.gitlab.com environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.


    :robot: This comment is generated automatically using the Release Tools project.

  • This merge request has been deployed to the release.gitlab.net environment, and will be included in the upcoming self-managed GitLab 13.5.0 release.


    :robot: This comment is generated automatically using the Release Tools project.

  • Please register or sign in to reply
    Loading