Replace Loading Button with Icon on All Vulnerability Lists
requested to merge KevSlashNull/gitlab:241763-Replace-Loading-Icon-With-Infinite-Scrolling into master
What does this MR do?
This MR replaces the loading button (text: Load more vulnerabilities) on all vulnerability lists (except the pipeline security tab) with a generic loading spinner.
Using the gl-infinite-scrolling component was suggested (here initially: #241763 (comment 405408279)) but was discarded (here: !41019 (comment 410472713)) because it does not work for this use-case currently.
Relates to #241763 (closed).
Screenshots
| Level | Video |
|---|---|
| Instance | VD: User scrolls down the instance-level vulnerability list, points to the loading spinner. |
| Group | VD: User scrolls down the group-level vulnerability list, points to the loading spinner. |
| Project | VD: User scrolls down the project-level vulnerability list, points to the loading spinner. |
| Pipeline | unchanged because it uses pagination! |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Kev