DAST Scanner Profiles Form MVC
Implements frontend for #235405 (closed)
/closes #235404 (closed)
What does this MR do?
This MR adds a basic form for creating DAST Scanner Profiles
- Adds a profile name field (required field)
- Adds a spider timeout (accepts number from 0 to 2880) (required field)
- Adds a target timeout (accepts number from 1 to 3600) (required field)
- Adds
Save Profile
btn which triggers GraphQL mutation - Adds
Cancel
btn which displays confirmation modal to discard changes
Prior work
- Groundwork was done at !39762 (merged)
- MR follows prior art for DAST Site Profiles at !36355 (merged), !38306 (merged)
Follow-up work
- Refactor DAST site form with a form helper - #244290 (closed)
- Redirect user to scanner-profile page - #235414 (comment 405703856)
Changelog
This MR doesn't require a changelog since the feature / button through which user can visit this page is behind a feature flag security_on_demand_scans_scanner_profiles
introduced in !40819 (merged)
Screenshots
Description | Screenshot |
---|---|
Initial Form with disabled submit button) | |
Valid form | |
Invalid form and validations | |
Discard state after clicking on cancel button | |
Errors |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Dheeraj Joshi